fix: allow unclosed single quotes in php-template (fixes #4152)#4374
Open
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Open
fix: allow unclosed single quotes in php-template (fixes #4152)#4374KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #4152 where a single apostrophe (unclosed quote) in php-template breaks highlighting for everything after it.
Problem
In php-template, an unclosed single quote like causes the entire remainder of the document to not be highlighted correctly. The issue does not occur in regular PHP mode.
Solution
Removed the
skip: trueproperty from the inherited APOS_STRING_MODE and QUOTE_STRING_MODE in php-template.js. This allows the parser to handle unclosed quotes more gracefully without breaking subsequent highlighting.Testing
Added a test case in
test/markup/php-template-apostrophe/default.txtthat reproduces the issue from the bug report.Reproduction